Fix wrong 4th arg in viscous gradient call#1230
Closed
sbryngelson wants to merge 1 commit into
Closed
Conversation
The finite-difference gradient call passed dq_prim_dy_qp (y-gradient) as the 4th argument instead of dq_prim_dz_qp (z-gradient). This meant the z-derivative was never computed in the FD path, and the y-derivative was written twice. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
codeant-ai
Bot
added
the
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the finite-difference viscous gradient computation where the z-direction gradient was incorrectly replaced with a duplicate y-direction gradient. The fix ensures that 3D viscous simulations using finite-difference methods now correctly compute all three spatial derivatives.
Changes:
- Corrected the 4th argument in
s_compute_fd_gradientcall fromdq_prim_dy_qp(1)%vf(i)todq_prim_dz_qp(1)%vf(i)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
- Coverage 44.07% 44.04% -0.03%
==========================================
Files 70 70
Lines 20431 20498 +67
Branches 1974 1990 +16
==========================================
+ Hits 9004 9029 +25
- Misses 10291 10330 +39
- Partials 1136 1139 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
dq_prim_dy_qp(1)%vf(i)as both the 3rd and 4th argumentsdq_prim_dz_qp(1)%vf(i)(z-gradient), matching the WENO branch above itTest plan
🤖 Generated with Claude Code
CodeAnt-AI Description
Fix viscous finite-difference so z-gradient is computed in 3D
What Changed
Impact
✅ Correct 3D viscous gradients✅ Fewer incorrect simulation outputs for 3D viscous cases✅ More accurate CFD results where z-derivative matters💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.